RFR: 8190353: [Testbug] test/hotspot/jtreg/gc/logging/TestPrintReferences.java can still fail

[sangheon.kim]

Hi Stefan,

Thank you for finding and fixing this bug.

On 10/30/2017 08:04 AM, Stefan Johansson wrote:
> Hi,
>
> Please review this fix for:
> https://bugs.openjdk.java.net/browse/JDK-8190353
>
> Webrev:
> http://cr.openjdk.java.net/~sjohanss/8190353/00/
>
> Summary:
> The fix for JDK-8188245 was incomplete, it removed the check that if 
> the reported time is longer than the sum of the sub-phases everything 
> is ok. The new code requires the sum of the sub-phases to be within a 
> give tolerance from the reported time. This is true in many cases but 
> we can't know for sure that we won't get a context switch or some 
> other stall between two sub-phases that causes the reported total time 
> to be longer, but the sub-phases to not include this extra time.
>
> Testing:
> Verified that the new verification method returns correct values for 
> different input values.
Looks good.

Just minor nit: you can ignore or no webrev is needed.
140   // Because of this we need method to verify that our measurements 
and calculations are valid.
-> Because of this_*,*_ we need _*a*_ method ...

Thanks,
Sangheon


>
> Thanks,
> Stefan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20171030/56df7beb/attachment.htm>