space.inline.hpp build failure

[Stefan Karlsson]

Looks good to me.

StefanK

On 2018-03-31 04:53, David Holmes wrote:
> Moving discussion to hotspot-gc-dev
> 
> David
> 
> On 30/03/2018 4:36 PM, Peter Johnson wrote:
>> When cross compiling either 9 or 10 to ARM with gcc 5.5.0, I get the
>> following linker error:
>> /tmp/cc7TKVtK.ltrans2.ltrans.o: In function
>> `OffsetTableContigSpace::block_start_const(void const*) const':
>> <artificial>:(.text+0x26e4): undefined reference to
>> `BlockOffsetTable::block_start(void const*) const'
>> /tmp/cc7TKVtK.ltrans13.ltrans.o: In function
>> `OffsetTableContigSpace::verify() const':
>> <artificial>:(.text+0x2ca6): undefined reference to
>> `BlockOffsetTable::block_start(void const*) const'
>> collect2: error: ld returned 1 exit status
>>
>> This appears to be due to a missing include in space.inline.hpp.  
>> Applying
>> the following patch fixes the build for me.
>>
>> Thanks,
>> Peter
>>
>> diff -r 5ab7a67bc155 src/share/vm/gc/shared/space.inline.hpp
>> --- a/src/share/vm/gc/shared/space.inline.hpp   Fri Sep 08 18:24:18 2017
>> +0000
>> +++ b/src/share/vm/gc/shared/space.inline.hpp   Thu Mar 29 23:25:25 2018
>> -0700
>> @@ -26,6 +26,7 @@
>>   #define SHARE_VM_GC_SHARED_SPACE_INLINE_HPP
>>
>>   #include "gc/serial/markSweep.inline.hpp"
>> +#include "gc/shared/blockOffsetTable.inline.hpp"
>>   #include "gc/shared/collectedHeap.hpp"
>>   #include "gc/shared/generation.hpp"
>>   #include "gc/shared/space.hpp"
>>