RFR: JDK-8209118: Abstract SATBMarkQueueSet's ThreadLocalData access

[Roman Kennke]

Submit-repo came back with UNSTABLE for this change. Can somebody with
access to the system check what it is, and if it relates to this change?

Thanks,
Roman

Build Details: 2018-08-09-0900164.roman.source
0 Failed Tests
Mach5 Tasks Results Summary

    NA: 0
    UNABLE_TO_RUN: 18
    PASSED: 53
    EXECUTED_WITH_FAILURE: 4
    KILLED: 0
    FAILED: 0
    Build

        5 Not run
            windows-x64-windows-x64-build-10 error while building,
return value: 2
            windows-x64-debug-windows-x64-build-11 error while building,
return value: 2
            windows-x64-install-windows-x64-build-17 Dependency task
failed: fmlDnaB6Xd
            windows-x64-open-windows-x64-build-12 error while building,
return value: 2
            windows-x64-open-debug-windows-x64-build-13 error while
building, return value: 2

    Test

        17 Not run

tier1-product-jdk_open_test_hotspot_jtreg_tier1_common-windows-x64-20
Dependency task failed: fmlDnaB6Xd

tier1-debug-jdk_open_test_hotspot_jtreg_tier1_common-windows-x64-debug-26
Dependency task failed: fmlDnaB7Xd

tier1-debug-jdk_open_test_hotspot_jtreg_tier1_compiler_1-windows-x64-debug-29
Dependency task failed: fmlDnaB7Xd

tier1-debug-jdk_open_test_hotspot_jtreg_tier1_compiler_2-windows-x64-debug-32
Dependency task failed: fmlDnaB7Xd

tier1-debug-jdk_open_test_hotspot_jtreg_tier1_compiler_3-windows-x64-debug-35
Dependency task failed: fmlDnaB7Xd

tier1-debug-jdk_open_test_hotspot_jtreg_tier1_compiler_not_xcomp-windows-x64-debug-38
Dependency task failed: fmlDnaB7Xd

tier1-debug-jdk_open_test_hotspot_jtreg_tier1_gc_1-windows-x64-debug-41
Dependency task failed: fmlDnaB7Xd

tier1-debug-jdk_open_test_hotspot_jtreg_tier1_gc_2-windows-x64-debug-44
Dependency task failed: fmlDnaB7Xd

tier1-product-jdk_open_test_hotspot_jtreg_tier1_gc_gcbasher-windows-x64-23
Dependency task failed: fmlDnaB6Xd

tier1-debug-jdk_open_test_hotspot_jtreg_tier1_gc_gcbasher-windows-x64-debug-47
Dependency task failed: fmlDnaB7Xd
            See all 17...


>> On Aug 8, 2018, at 11:35 AM, Roman Kennke <rkennke at redhat.com> wrote:
>>
>> Hi Kim,
>>
>> Thanks for reviewing!
>>
>>>> Bug:
>>>> https://bugs.openjdk.java.net/browse/JDK-8209118
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~rkennke/JDK-8209118/webrev.00/
>>>> Testing: hotspot/jtreg:tier1 (fastdebug)
>>>>
>>>> Can I please get reviews?
>>>>
>>>> Thanks,
>>>> Roman
>>>
>>> Oops, we seem to have mis-communicated; I was working on a similar
>>> change.  You published first, so we'll go with yours; it makes for an
>>> easy review, since the code looks very familiar :)
>>
>> Oh, sorry. Well possible that I missed something between travelling and
>> some crazy stuff here.
> 
> I think we just left it unclear which of us was going to do this part.
> 
>>> One other piece of work related to sharing the SATB buffer code is
>>> G1SATBBufferEnqueueingThresholdPercent.  That's going to need to be
>>> renamed or something, which will involve the CSR process.
>>
>> Yeah. Or else introduce new $GCSATBBufferEnqueueingThresholdPercent ;-)
> 
> If it’s going to be a product flag (like the present G1 flag is), that’s going to need
> the CSR process too.  And we’ll also need to change how it’s checked, since
> it is presently a direct reference to the option in what we want to be shared code.
> Probably the way to do that would be to add a member to the QSet that is
> initialized (from GC-specific code with the GC-specific value).
> 
> Let’s deal with this separately from this change though.
> 
>> Incremental:
>> http://cr.openjdk.java.net/~rkennke/JDK-8209118/webrev.01.diff/
>> Full:
>> http://cr.openjdk.java.net/~rkennke/JDK-8209118/webrev.01/
>>
>> Better?
> 
> Looks good.
>