RFR: 8209396: Make PtrQueueSets not statically allocated
Thomas Schatzl
thomas.schatzl at oracle.com
Mon Aug 13 08:19:17 UTC 2018
Hi again,
On Mon, 2018-08-13 at 10:00 +0200, Thomas Schatzl wrote:
> Hi Kim,
>
> On Sun, 2018-08-12 at 18:07 -0400, Kim Barrett wrote:
> > Please review this change to G1BarrierSet to make its two
> > PtrQueueSet
> > members (_satb_mark_queue_set and _dirty_card_queue_set) be
> > ordinary
> > data members rather than static data members.
> > [...]
> >
> > CR:
> > https://bugs.openjdk.java.net/browse/JDK-8209396
> >
> > Webrev:
> > http://cr.openjdk.java.net/~kbarrett/8209396/open.00/
> >
>
> looks good.
>
> Please consider moving the return statement at g1BarrierSet.cpp:66 to
> a new line and add braces.
This also means that I do not need a re-review either way.
Thanks,
Thomsa
More information about the hotspot-gc-dev
mailing list