RFR (M): 8209061: Move G1 serviceability functionality to G1MonitoringSupport

Thomas Schatzl thomas.schatzl at oracle.com
Mon Aug 13 09:03:33 UTC 2018


Hi,

On Fri, 2018-08-10 at 16:51 +0000, Hohensee, Paul wrote:
> Hi Thomas,
> 
> LGTM, except,
> 
> g1MonitoringSupport.hpp:
> Is there a way to avoid making G1MonitoringScope be a friend class to
> G1MonitoringSupport?

  I could add four trivial (single-use) getters that imho do not
improve readability. And with the new MXBeans this number will increase
a bit iirc.

G1MonitoringSupport and its G1MonitoringScope are very much closely
related; G1MonitoringScope is extremely simple as well, so I would
prefer to keep it as is.

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list