RFR (M): 8209061: Move G1 serviceability functionality to G1MonitoringSupport

[sangheon.kim at oracle.com]

Hi Thomas,

On 8/8/18 3:54 AM, Thomas Schatzl wrote:
> Hi all,
>
>    can I have reviews for this cleanup that moves all serviceability
> functionality into the G1MonitoringSupport class.
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8209061
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8209061/webrev/
> Testing:
> hs-tier1-4, jdk-tier1-3
Looks good.

Just minor nits.
src/hotspot/share/gc/g1/g1FullGCScope.hpp
src/hotspot/share/gc/g1/g1MonitoringSupport.cpp
- Remove '#include "gc/shared/collectorCounters.hpp"'

src/hotspot/share/gc/g1/g1FullGCScope.cpp
src/hotspot/share/gc/g1/g1FullGCScope.hpp
- Copyright update

I don't need a new webrev for this change.

FYI, you will face conflict with latest source code at 
g1CollectedHeap.cpp(probably because of -Wreorder patch? ), but I think 
it is simple enough to go without a new webrev. :)

Thanks,
Sangheon


>
> Depends on JDK-8208498 also out for review.
>
> Thanks,
>    Thomas
>