RFR: 8209883: ZGC: Compile without C1 broken

Aleksey Shipilev shade at redhat.com
Thu Aug 23 08:04:05 UTC 2018


On 08/23/2018 10:00 AM, Per Liden wrote:
> zBarrierSetAssembler_x86.cpp doesn't compile when C1 is disabled. Also JDK-8207965 introduced uses
> of COMPILER{1,2}_PRESENT macros in ZBarrierSet, which instead should be solved with forward
> declarations.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8209883
> Webrev: http://cr.openjdk.java.net/~pliden/8209883/webrev.0

I think you want #include "utilities/macros.hpp" to gain access to COMPILER{1,2} definitions without
PCH, see how {cardTable,epsilon,g1}BarrierSet do it.

Otherwise looks trivial and good.

-Aleksey


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20180823/196e3418/signature.asc>


More information about the hotspot-gc-dev mailing list