RFR: 8209883: ZGC: Compile without C1 broken

[Per Liden]

Thanks Erik!

/Per

On 08/23/2018 02:33 PM, Erik Österlund wrote:
> Hi Per,
> 
> Looks good.
> 
> Thanks,
> /Erik
> 
> On 2018-08-23 10:29, Per Liden wrote:
>> Hi,
>>
>> On 08/23/2018 10:04 AM, Aleksey Shipilev wrote:
>>> On 08/23/2018 10:00 AM, Per Liden wrote:
>>>> zBarrierSetAssembler_x86.cpp doesn't compile when C1 is disabled. 
>>>> Also JDK-8207965 introduced uses
>>>> of COMPILER{1,2}_PRESENT macros in ZBarrierSet, which instead should 
>>>> be solved with forward
>>>> declarations.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8209883
>>>> Webrev: http://cr.openjdk.java.net/~pliden/8209883/webrev.0
>>>
>>> I think you want #include "utilities/macros.hpp" to gain access to 
>>> COMPILER{1,2} definitions without
>>> PCH, see how {cardTable,epsilon,g1}BarrierSet do it.
>>
>> Good point. This compiles without PCH, since thread.hpp happens to 
>> include macros.hpp, but we should not rely on that here. Added the 
>> proper include and updated the webrev in-place.
>>
>>>
>>> Otherwise looks trivial and good.
>>
>> Thanks for reviewing.
>>
>> /Per
>>
>>>
>>> -Aleksey
>>>
>>>
>