RFR: JDK-8180193: Make marking bitmap code available to other GCs

Roman Kennke rkennke at redhat.com
Fri Aug 24 16:10:56 UTC 2018


Am 24.08.2018 um 18:06 schrieb Roman Kennke:
> Am 24.08.2018 um 14:15 schrieb Aleksey Shipilev:
>> On 08/24/2018 01:51 PM, Roman Kennke wrote:
>>> This moves marking bitmap code to gc/shared, at least the parts that are
>>> not G1 specific. The only minor functional change is in check_mark():
>>> replace is_in_exact() with is_in_reserved(). If that is not ok, then we
>>> may want to introduce virtual is_in_exact() in CollectedHeap?
>>>
>>> Bug:
>>> https://bugs.openjdk.java.net/browse/JDK-8180193
>>> Webrev:
>>> http://cr.openjdk.java.net/~rkennke/JDK-8180193/webrev.00/
>>
>> *) Stray file:
>>   src/hotspot/share/gc/shared/concurrentMarkBitMap.hpp~
>>
>> *) Do we really need to call it *concurrent*MarkBitMap? I think shorter markBitMap is enough.
>>
>> *) Ditto for the class name. It seems MarkBitMap is enough.
>>
> Thanks Aleksey for reviewing. I fixed all of the above:
> 
> http://cr.openjdk.java.net/~rkennke/JDK-8180193/webrev.01/
> 

Oops, this included the cmpxchg_oop patch I did have applied still. Look
at this:

http://cr.openjdk.java.net/~rkennke/JDK-8180193/webrev.02/

Roman




More information about the hotspot-gc-dev mailing list