RFR (XS) 8210192: Hsperf counter ParNew::CMS should be ParNew:CMS

[Man Cao]

Thanks for the review!
Should we wait for another "looks good" before JC can submit it?

Since the testing infrastructure did not catch this change, should we add a
test for this hsperf counter?

PS: I found a better command to test for its value:
$ jstat -J-Djstat.showUnsupported=true -snap file:///$(pwd)/test.hsperf |
grep sun.gc.policy.name

-Man


On Thu, Aug 30, 2018 at 1:52 AM Stefan Johansson <
stefan.johansson at oracle.com> wrote:

>
>
> On 2018-08-30 02:29, Man Cao wrote:
> > Hi all,
> >
> > I noticed a possible slight naming bug for the HSPerf
> > counter "sun.gc.policy.name <http://sun.gc.policy.name>", introduced by
> > http://hg.openjdk.java.net/jdk/jdk/rev/170c7b36aea6.
> >
> > Basically instead of "ParNew:CMS", the counter's value is now
> "ParNew::CMS".
> >
> > Here is a fix for the bug, could someone review it?
> >
> > Webrev: http://cr.openjdk.java.net/~jcbeyler/8210192/webrev.00/
> > <http://cr.openjdk.java.net/%7Ejcbeyler/8210192/webrev.00/>
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8210192
>
> Looks good and since the bug hasn't shown up in our testing I don't
> think fixing it back should be a problem testing wise.
>
> Thanks,
> StefanJ
>
> >
> > PS: Thanks JC for creating the bug and hosting the webrev!
> >
> > Thanks!
> > Man
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20180830/8484551f/attachment.htm>