Request for CSR review: 8214349: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

[Per Liden]

On 2018-12-04 21:42, Roman Kennke wrote:
> Hi Per and all,
> 
> The CSR is still waiting for reviews from Hotspot-GC reviewers. Could
> you, or one of you, review the Shenandoah flags CSR, if you find some
> time? I believe it's important that once you've done it, you put your
> name under 'Reviewed-by' field, which can be found under the 'Edit' button.
> 
> https://bugs.openjdk.java.net/browse/JDK-8214349

Reviewed.

cheers,
Per

> 
> Thanks,
> Roman
> 
>> Hi,
>>
>> On 11/29/18 3:41 PM, Roman Kennke wrote:
>> [...]
>>> I would not like to change acronyms in flags like SATB to Satb. This
>>> would look *very* odd to me, and inconsistent too. Every other flag that
>>> has SATB in it uses just SATB.
>>>
>>> Other such acronyms used in our flags are: GC, TLAB and CAS. I don't
>>> think any of them are better as Gc, Tlab or Cas. I'd very much prefer to
>>> keep them as they are.
>>
>> I agree. There must be some kind of misunderstanding here. Like you say,
>> for JVM flags (as opposed to the JDK API) the convention is to use
>> uppercase acronyms. Using something different for Shenandoah would be
>> very odd, to say the least.
>>
>> cheers,
>> Per
>