RFR (S): 8214791: Rename vm_operations_g1* files to g1VMOperations*

Thomas Schatzl thomas.schatzl at oracle.com
Wed Dec 5 09:48:27 UTC 2018


Hi,

On Tue, 2018-12-04 at 17:10 -0500, Kim Barrett wrote:
> > On Dec 4, 2018, at 11:40 AM, Thomas Schatzl <
> > thomas.schatzl at oracle.com> wrote:
> > 
> > Hi all,
> > 
> >  can I have reviews for this renaming of the vm_operations_g1*
> > files
> > to something more fitting? Other than that only includes and the
> > #define has been fixed.
> > 
> > CR:
> > https://bugs.openjdk.java.net/browse/JDK-8214791
> > Webrev:
> > http://cr.openjdk.java.net/~tschatzl/8214791/webrev/
> > Testing:
> > local compilation
> > 
> > Thanks,
> >  Thomas
> 
> Coleen and I talked about this, and neither of us wants yet another
> naming convention for these files.
> See her comment in the bug report for her
> preference.  (vmG1Operations).  I don’t care that much
> about the specifics, so long as there is consistency (which there
> admittedly is not, at present, but
> this proposed change just makes that worse).
> 

I could rename the other gc files too to make them consistent, e.g.
cmsVMOperations :)

However I can be convinced to go with vmG1Operations although it does
read backwards imho. At least it gets rid of the underscore.

New webrev with that latter change:
http://cr.openjdk.java.net/~tschatzl/8214791/webrev.1

Thanks,
  Thomas





More information about the hotspot-gc-dev mailing list