RFR 8204947: Port ShenandoahTaskTerminator to mainline and make it default
zgu at redhat.com
zgu at redhat.com
Wed Dec 5 15:16:25 UTC 2018
Thanks, Bernd.
On Wed, 2018-12-05 at 14:46 +0000, Bernd Eckenfels wrote:
> html {
> background-color: transparent;
> }
>
> body {
> color: #333;
> line-height: 150%;
> font-family: "-apple-system", "HelveticaNeue";
> margin: 0;
> }
>
> .ms-outlook-ios-reference-expand {
> display: block;
> color: #999;
> padding: 20px 0px;
> text-decoration: none;
> }
>
> .ms-outlook-ios-availability-container {
> max-width: 500px;
> margin: auto;
> padding: 12px 15px 15px 15px;
> border: 1px solid #C7E0F4;
> border-radius: 4px;
> }
>
> .ms-outlook-ios-availability-container > .ms-outlook-ios-
> availability-delete-button {
> width: 25px;
> height: 25px;
> right: -12px;
> top: -12px;
> background-image:
> url("data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAEsAAABLCAYAAAA4Tn
> rqAAAAAXNSR0IArs4c6QAACxpJREFUeAHlnFuMXlUVx/fcOzNtp0ynF0U7hWKrEmKLosZ
> EjUZ9MgZIQBNC0uAtJr745oOJIT74xgskJkQbAlQNJmBMfNDEG0YjEC7GIBQZ6IAI005L
> 79O5+/+dfut0f5dzzt7nu8w37UrWt893zt5rr/U/e6+zL+ucHrcGtLq62q9qd4gnxTeKb
> 6kcc267eEI8Kz4mnhFPi58Rv1g5nunp6VnS8ZVHAqdHPCk+KP6zuBWEHORNinvWNWoYIN
> 4q/o74mLidhHzqob71AxzKij8g/p14LYh6qb97QUM58T7x38TdQOiBPt0FmhQaEf9M3I2
> EXiNr7tOkBK3pVvGCuJsJ/dCzqVbWWxZxVTygso+InxBz3M2Efuj5SEXvUrqWQloV7lRt
> T4vfX6rWtS30pqr/uMZp78SqEQ2WgPqQKvmnuKWtaWnFuaWVVbciXl51rk+a9fb2uP6EY
> 80qzL+oHB8RYC8V5vQyRIEloD6tsk965UsdAsyZ+WV35uKyOz+/4uZ0YgmEMqhfyA3397
> rRoV63eUOf2zzUJxAzMsed/owA+2tokWCwmgVKDcadvLDsZs8vutMXV5zkhepYl08GurE
> NvW5idMCNj/Q5Nb5mKBiwoGoqXe/fZTQCkmNnl9x/Ty+4xZzW0yeLB9WC6Hp0QbLSJRd0
> sAzSGTSgzO8bG3TbN/W7IGMay/lwSJcslC+gcOZviKN9FC3pjVML7uKi+l0NDakf0Sq2D
> Pe5kYFeh9FZBMgXJOPU3HLSOufpxzW0QTJ2bRlMZNZcCvmLD9slwHKdfraGKi2gAGhKHP
> XUm1tcdVMn5t05+SWfMGjbaL+7RiABUFkCuHd1I46fX6q7ERvlz/ZsHXLDA7mmNaqap+Q
> eAQZwDSlTooDiGuOouxqWzDjJ3X91dj55slkWWs216io7musqJi5N6Zwz6uJv1XRxnqA3
> TAwlrTbNHHZwWNnuFmAN+30eWLeqIAO5YHr7zKK63WLqvPFDOzcNuPeODSR+KFhQZEb82
> /9OL7p3zi6m/k0Gq1sOuPdsjvYet6nsrxup0BAstSrmUqfEQTVxG147seCOn7vcguly+7
> ZtKNMdGukZdI7uf+T4xaquuW3jgLt+62CM88eILQLsQm2ldY6j0v3uV8YgoBBYC9SYxkI
> 37RzuKFDogZ+iXuo34gaiXwRh9/0VHKqK1bUsZdqnHC9X5cr5Q9ebfveyMnS73eODOSU6
> c+noyYWkW1ptk9cMxnbJD6p1HbHypFUtq4LmIT9D3jHOHB9l1C1AoQ83DH2M0BN9I+hQb
> euqAkuCbhB/KkQg/oGnngQm2Wn63dCifN3Rx7okeqIvegcSOIBHSilYFRQfSK8UHDCOYu
> IL4cz3ypl3I6EX+kHoi94R9IDfulKwJGBc/KUQQYzMbcDJ8ICnXp8vKURIh/Kg1yX9Lrl
> n9Eb/QAIPcEnIN/FOO5mX0paYwhjhF0qMlq14R1L0q/ZfCy64MzqX4pKAVWlq94ZozqTY
> 5nqMzBlwrgdCT5t/oj92BNK91hWtZe1SwW1FhXFRrB4YMYXJmf9atiRl7vvz52fd4/86G
> XNXq2TYH1oFch59blZ+yM7mp+iJvkbYkbOYYdlIwQV8HNvo0OcuJfm/9HVbZsFpMtcLpV
> ++MOvuPvyfJPs9n9jufnrnnphRdVoNQH3jsSl36Cl29l0i466b2e0vJvRlSkTLwg7smRi
> 9PIDNkQA+D1nL+nZOxvQSC3dGrB7oZgXTcOWJRAEMxeAIv5HUUwsUJ325SaacH/RFbyPf
> HjuXkR7kfK/6I03sk/zJI5o7K5xGLLPE0O03jTtalFEsYI2AQt5tkhtDvt7YE9iNPyuck
> pXsj4VUxnq5CiRZWbiLXY/irtL1ygCWBVSZroze6A9hD3YF0g5KMRcsJDYYjFjhLENlAG
> slUKazr79vl13PSCeDwWIXxoil4LIUA1g7gEJvX3/frgKbbgSsvQWZkstsVxnFdkErZ2k
> IYO0CCh18/X27TL+M9BbA2ppxMT0NTravx/TGBndphhIHeYCx8ukPDxDfzHCjVj30xw4I
> u7x2UJvV/z/Jc3STf6bRsU2YucZ2VavIAEOejZtIn5w6qxWCubSaVgJlQrFjrjIqxT7W7
> QsocfCFYPn7dnZHCgQHXzbA/Kdku4FCOd8O374cxXfSDYdzMiSX/GlB8Q0oklZ/HcAevG
> OPdmSqVeE/5wvveb3IwjO+Hb59OQXHAatuYb62QAnBtSJy/+PMv/WrqaquRwFaGOe53mr
> CLxoFepZZwDpnhbLSEk02S1TdeXSudeZ+C4sd6ddVkHGC0AAjQgYC6BhgnS3K6Ds/Yg9a
> RY2Awne9/P39pUb6MXr5dvj25ciYAawTORmSS8wOCPuBcIa28pCcKPmTBRRTGKoqOzUKU
> Qf9zaljV2X2U1R0GrBeKcrFdeKjjIg1aIbygLIOQdouwHz9fbsKbHoGBKr2xrIKEEhmFL
> mlZMWSNAQoK9AuwHz9fbus3oz0xWCwiLYziljwtyJJGgOUFWwHYL7+RBIGUtINnw3JjFC
> CLSDio/ymHFK+DFAmt5WAobfFd2GP3wisvox0plcFpnXxtYwM6WlcFqGJRsRHxdATWjO3
> KQ3lYqcwWYAhN4Z8vbHHc8V5Yv4inJbM+j/l5bRrxHAaEUhGawmlOe+hEAuU1dEIMF+u5
> ctK0Re9jXx77FxG+hDnqZ8Vw68p+QXHecQ47vm3LqRDh93jQ9qPu7ymnVeWmT2bFqyZs8
> ScVJxXIOcaRtOiAOqr+ydCW4c2K5bc0ZOXdqRZeThw7Uho8O5ueqCBtVH1E085mqNjcol
> Iu9e9CverwsoQrKjoml5nLP2Cd6Ov040O3J06LsV3CKzVpBvqgClPUJQfUcEWO8Dgjoi7
> 9UDoaYNp9MeOQPohQJHXfBbHD/NTRDRFooKN2IeLiEyxYh1N0e9t6WmE/hFu4DEr54P1B
> 50MGs2z4E9UMMS0gdDE5eYG9YmsdvygF/rZxBm9/Q2Lgjp/r+vp4zYFS00Nc39cUDi9TP
> i0TUDZ4X1FCnUjoZfFZqAvekfQd60LUiYFqyLgUaXTlePchMgUwqclLMl3WvtvhCZ2E6E
> PekHoib4RET9/V7FXk8KVnyqwJJBByI/8DHnHbCkRPm2E/+oWwGpjStHT3wIznXPSe/xW
> Rb4qsCoFDyl9qnJcmBBnTvi0EYC9NLN2PgwfRf3oYYR+kfHwYFDnvxs+FDRIPaDMfHQia
> JbJc7U2vJvH85UWB98QLNnOqP4+Jd/jOJTW+g0Lhgf21MNHdeQNC8ARWAymcHIf5X8osV
> Z01b27AzgC7Holz4nH+B9KDAKvqrfCDBgB9hUdPy4O8l9WjpRFtqvmfUMzXIB9U8cP2v+
> YFOcf8yYr227sTLHCwexgXb3JasAIsB/oOHgMZuUsxXha2hX/jrQZ3CxgJoe1LSLuCCSL
> fvteczuWuANXOK3KrDT4ZXIEZA4dsqRXuuRPdD3ah2XJ5DwAEs1C16MV0hXpksznWgSMX
> z0j1vZ+18FqE2A4/YfFUU9JK7/G6Zuqv9QXQxpNdwpt0YDvN8p0szhoZ6hQYOcyHFZVvD
> Se+5Z9W9RRCxsU3ydeEnczteQrRy0BUSgdEP+jS9Hqju9n+UgLKL6l9XXx0S4BrTu/zFY
> DWr/AOig+skagdf83/3zAOBZQvOryRTEf+Donbid15GuS0eOsWlBC/gsl9iW/LP6C+PPi
> 68TN0usS8EcxH6z4be2qZrPCG5XvCFi1FQu8SZ1j6YdXYeC9YuLxiZyGicQltpuoRPiEm
> JVLwqPgZwXOtNKO0v8BzRAPSFNM7HEAAAAASUVORK5CYII=");
> background-size: 25px 25px;
> background-position: center;
> }
>
> #ms-outlook-ios-main-container {
> margin: 0 0 0 0;
> margin-top: 120;
> padding: 8;
> }
>
> #ms-outlook-ios-content-container {
> padding: 0;
> padding-top: 12;
> padding-bottom: 20;
> }
>
> .ms-outlook-ios-mention {
> color: #333;
> background-color: #f1f1f1;
> border-radius: 4px;
> padding: 0 2px 0 2px;
> pointer-events: none;
> text-decoration: none;
> }
>
> .ms-outlook-ios-mention-external {
> color: #ba8f0d;
> background-color: #fdf7e7;
> }
>
> .ms-outlook-ios-mention-external-clear-design {
> color: #ba8f0d;
> background-color: #f1f1f1;
> }
>
>
>
> There is a typo and I think you don’t need to repeat the
> abbreviation:
>
>
>
> "Use Optimized Work Stealing Threads task termination protocol"
>
>
>
> In gc_Globals.hpp
Fixed:--- a/src/hotspot/share/gc/shared/gc_globals.hpp Tue Dec
04 11:54:13 2018 -0500+++
b/src/hotspot/share/gc/shared/gc_globals.hpp Wed Dec 05 10:12:25
2018 -0500@@ -349,7 +349,7 @@ "Total collections between
promotion failures a
lot") \
\ diagnostic(bool, UseOWSTTaskTerminator,
true, \- "Use OWST(Optomized Work
Stealing Threads) task termination " \+ "Use Optimized
Work Stealing Threads task termination
" \ "protocol")
\
-Zhengyu
>
>
>
>
>
> Gruss
> Bernd
> --
> http://bernd.eckenfels.net
>
>
>
>
> Von: hotspot-gc-dev <hotspot-gc-dev-bounces at openjdk.java.net> im
> Auftrag von zgu at redhat.com
>
> Gesendet: Mittwoch, Dezember 5, 2018 3:34 PM
>
> An: Roman Kennke; Kim Barrett; Thomas Schatzl
>
> Cc: hotspot-gc-dev at openjdk.java.net
>
> Betreff: Re: RFR 8204947: Port ShenandoahTaskTerminator to mainline
> and make it default
>
>
>
>
> > > > I also think what's being proposed here is more of a
> diagnostic
>
> > > > than
>
> > > > experimental flag. I think an experimental flag ought to be
> opt-
>
> > > > in,
>
> > > > e.g. off by default but one can choose to take the risk. A
>
> > > > diagnostic
>
> > > > flag can be used to opt-out of the "normal" behavior, in this
>
> > > > case to
>
> > > > revert back to the old behavior. Of course, we violate that a
>
> > > > lot...
>
> > >
>
> > > I agree. Diagnostic seems to fit the purpose better.
>
> >
>
> > Thanks for the suggestion, I changed the flag to diagnostic.
> Please
>
> > see
>
> > updated webrev: http://cr.openjdk.java.net/~zgu/JDK-8204947/webrev.
> 03
>
> > /
>
> >
>
> Ping!
>
>
>
> I updated weberv to incorporate Thomas Schatzl's suggestions, mainly
>
> are style and comment changes.
>
>
>
> Incremental: http://cr.openjdk.java.net/~zgu/JDK-8204947/webrev.04_in
> c/
>
> Full: http://cr.openjdk.java.net/~zgu/JDK-8204947/webrev.04/
>
>
>
> Thanks,
>
>
>
> -Zhengyu
>
>
>
>
>
>
>
> > I also wanted to update CSR
>
> > (https://bugs.openjdk.java.net/browse/JDK-8214458) to reflect this
>
> > change, but I could not add comments, that made me wonder if I can
>
> > update text when it is in "provisional" status? or do I need to
> move
>
> > back to "draft" to do so?
>
> >
>
> > Anyway, could you please review CSR also?
>
> >
>
> > FYI:
>
> > Webrev02 passed vmTestbase_vm_gc and submit tests.
>
> >
>
> > Thanks,
>
> >
>
> > -Zhengyu
>
> >
>
> >
>
> >
>
> >
>
> >
>
> > >
>
> > > Roman
>
> > >
>
> > >
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20181205/107f2558/attachment.htm>
More information about the hotspot-gc-dev
mailing list