RFR: 8213224: Move code related to GC threads calculation out of AdaptiveSizePolicy

[Man Cao]

Thank JC for the fast response, and sorry for the oversight.

-Man

On Sat, Dec 8, 2018, 13:18 JC Beyler <jcbeyler at google.com wrote:

> Hi Roman,
>
> I filed a bug here: https://bugs.openjdk.java.net/browse/JDK-8215043
>
> and I have a webrev that I'll send up for review in a separate email.
>
> Sorry about that,
> Jc
>
> On Fri, Dec 7, 2018 at 12:02 PM Roman Kennke <rkennke at redhat.com> wrote:
>
>> It is already pushed, but I noticed you have removed the definition of
>> Abstract_VM_Version::parallel_worker_threads() but the declaration is
>> still there. One can code against this but then get linker failure.
>> Maybe also remove:
>>
>> static unsigned int parallel_worker_threads();
>>
>> in vm_version.hpp?
>>
>> Roman
>>
>> > Could anyone review this cleanup change?
>> > In addition to straight code movement, it removes unnecessary dependency
>> > on adaptiveSizePolicy.hpp in G1 code, and removed unnecessary include
>> > statements in adaptiveSizePolicy.hpp/cpp.
>> >
>> > Webrev: https://cr.openjdk.java.net/~manc/8213224/webrev.00/
>> > RFE: https://bugs.openjdk.java.net/browse/JDK-8213224
>> > Tested on submit repo with the help from JC (CCed).
>> >
>> > Thanks,
>> > Man
>>
>>
>
> --
>
> Thanks,
> Jc
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20181208/d94ebaca/attachment.htm>