RFR (XS) 8215120: 32-bit build failures after JDK-8212657 (Promptly Return Unused Committed Memory from G1)

Aleksey Shipilev shade at redhat.com
Mon Dec 10 14:33:45 UTC 2018


Thanks, pushed.

-Aleksey

On 12/10/18 3:30 PM, Roman Kennke wrote:
> Looks good and trivial to me.
> 
> Thanks,
> Roman
> 
>> Welcome to the "Gold Rush for JDK 12" week! Take a shovel!
>>
>> Bug:
>>   https://bugs.openjdk.java.net/browse/JDK-8215120
>>
>> Fix:
>>
>> 8215120: 32-bit build failures after JDK-8212657 (Promptly Return Unused Committed Memory from G1)
>> Reviewed-by: XXX
>>
>> diff -r f94c7929a44b -r e1f2ce8b31c7 src/hotspot/share/gc/g1/g1_globals.hpp
>> --- a/src/hotspot/share/gc/g1/g1_globals.hpp    Mon Dec 10 10:25:27 2018 +0100
>> +++ b/src/hotspot/share/gc/g1/g1_globals.hpp    Mon Dec 10 12:20:24 2018 +0100
>> @@ -305,7 +305,7 @@
>>    manageable(uintx, G1PeriodicGCInterval, 0,                                \
>>            "Number of milliseconds after a previous GC to wait before "      \
>>            "triggering a periodic gc. A value of zero disables periodically "\
>>            "enforced gc cycles.")                                            \
>> -          range(0, max_jlong)                                               \
>> +          range(0, max_uintx)                                               \
>>                                                                              \
>>    product(bool, G1PeriodicGCInvokesConcurrent, true,                        \
>>            "Determines the kind of periodic GC. Set to true to have G1 "     \
>>            "perform a concurrent GC as periodic GC, otherwise use a STW "    \
>>
>>
>> It is wise to use the matching type constants anyway. uintx != jlong on 32-bit platforms.
>>
>> Testing: Linux {x86_64, x86_32}L: builds, ad-hoc gc/g1/TestPeriodicCollection test
>>
>> -Aleksey
>>
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20181210/79756bee/signature.asc>


More information about the hotspot-gc-dev mailing list