RFR(S): 8215114: Fix indent and dead code in GCPolicyCounters
Stefan Johansson
stefan.johansson at oracle.com
Wed Dec 12 10:32:02 UTC 2018
On 2018-12-12 06:49, Man Cao wrote:
> Thanks for the review!
>
> Is only one review sufficient to push this change?
> In general, is it the case that if any reviewer indicates "trivial",
> only one review is required?
Here's another one :)
Looks good,
StefanJ
>
> PS: I read about this page:
> https://wiki.openjdk.java.net/display/HotSpot/Pushing+a+HotSpot+change
> but it doesn't say trivial changes only need one review.
>
> -Man
>
>
> On Mon, Dec 10, 2018 at 6:13 PM Thomas Schatzl
> <thomas.schatzl at oracle.com <mailto:thomas.schatzl at oracle.com>> wrote:
>
> Hi,
>
> On Mon, 2018-12-10 at 18:04 +0800, Man Cao wrote:
> > Hi all,
> >
> > Can I have reviews for this small cleanup?
> >
> > Webrev: https://cr.openjdk.java.net/~manc/8215114/webrev.00/
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8215114
> >
>
> looks good and trivial.
>
> Thomas
>
>
More information about the hotspot-gc-dev
mailing list