RFR(M): 8211425: Allocation of old generation of java heap on alternate memory devices - G1 GC

[Stefan Johansson]

Hi Kishor,

The latest webrev fail to compile when pre-compiled headers is disabled. 
It is caused by a missing include in g1HeterogenouesCollectorPolicy.cpp, 
you need to include "runtime/globals_extension.hpp.

On 2018-12-13 11:14, Kharbas, Kishor wrote:
> Missed one change earlier -
> http://cr.openjdk.java.net/~kkharbas/8211425/webrev.13/
Some more comments.
src/hotspot/share/gc/g1/g1YoungGenSizer.cpp
-------------------------------------------
133 G1YoungGenSizer* G1YoungGenSizer::create_gen_sizer() {
  134   if (AllocateOldGenAt != NULL) {
  135     return new G1HeterogeneousHeapYoungGenSizer();
  136   } else {
  137     return new G1YoungGenSizer();
  138   }
  139 }

I think it is nicer if you pass down the G1CollectorPolicy and check 
is_hetero_heap().

test/hotspot/jtreg/TEST.groups
------------------------------
Remove the { } from the added lines otherwise the exclude won't work, 
and the test groups will be broken.

src/hotspot/share/gc/g1/g1Policy.cpp
------------------------------------
Remove the printf on line 188.

Call delete _young_gen_sizer in the destructor.

src/hotspot/share/gc/g1/g1HeterogeneousCollectorPolicy.cpp
----------------------------------------------------------
Remove line 54, that variable is never used.

Same problem as for Parallel that the log message might not be correct.

src/hotspot/share/gc/g1/g1HeterogeneousHeapYoungGenSizer.cpp
------------------------------------------------------------
51 void 
G1HeterogeneousHeapYoungGenSizer::adjust_lengths_based_on_dram_memory() {
52   _min_desired_young_length = MAX2(_min_desired_young_length, 
_max_young_length);
53   _max_desired_young_length = MAX2(_max_desired_young_length, 
_max_young_length);
54 }

Those should do MIN2(). Otherwise you won't limit as intended.

Thanks,
Stefan
> http://cr.openjdk.java.net/~kkharbas/8211425/webrev.12_to_13/
>
> Thanks
> Kishor
>