RFR(M): 8211425: Allocation of old generation of java heap on alternate memory devices - G1 GC

Kharbas, Kishor kishor.kharbas at intel.com
Sat Dec 15 02:04:55 UTC 2018


Thanks for the review,

New webrev at - http://cr.openjdk.java.net/~kkharbas/8211425/webrev.15
http://cr.openjdk.java.net/~kkharbas/8211425/webrev.14_to_15

Regards
Kishor

> -----Original Message-----
> From: Stefan Johansson [mailto:stefan.johansson at oracle.com]
> Sent: Friday, December 14, 2018 2:40 AM
> To: Kharbas, Kishor <kishor.kharbas at intel.com>; sangheon.kim at oracle.com
> Cc: 'hotspot-gc-dev at openjdk.java.net' <hotspot-gc-dev at openjdk.java.net>;
> 'Hotspot dev runtime' <hotspot-runtime-dev at openjdk.java.net>;
> Viswanathan, Sandhya <sandhya.viswanathan at intel.com>
> Subject: Re: RFR(M): 8211425: Allocation of old generation of java heap on
> alternate memory devices - G1 GC
> 
> Hi Kishor,
> 
> I have one (maybe last) comment on this and it is basically the same thing as
> I commented on for Parallel. I think you should use FormatBuffer instead of a
> raw char buffer in the sizing code.
> 
> Cheers,
> Stefan
> 
> On 2018-12-14 08:54, Kharbas, Kishor wrote:
> > Hi Sangheon, Stefan,
> >
> > I have updated webrev at -
> > http://cr.openjdk.java.net/~kkharbas/8211425/webrev.14/
> > http://cr.openjdk.java.net/~kkharbas/8211425/webrev.13_to_14
> >
> > This webrev works on the latest comments and has some changes in young
> generation sizing logs messages.
> > I am re-running jtreg tests with this patch.
> >
> > Thanks,
> > Kishor
> >


More information about the hotspot-gc-dev mailing list