RFR: JDK-8206407: Primitive atomic_cmpxchg_in_heap_at() in BarrierSet::Access needs to call non-oop raw method

Per Liden per.liden at oracle.com
Thu Jul 5 15:26:01 UTC 2018


On 07/05/2018 05:00 PM, Roman Kennke wrote:
> Hi Per,
> 
>>> BarrierSet::Access:atomic_cmpxchg_in_heap_at() is currently calling
>>> Raw::oop_atomic_cmpxchg_at() which is obviously wrong.
>>>
>>> We've been lucky because primitive is not bound in default OpenJDK.
>>>
>>> Even in Shenandoah land we've been lucky because primitives don't match
>>> narrowOop and thus don't get (attempted to) encoded/decoded.
>>>
>>> Lucky us.
>>>
>>> Let's fix it anyway:
>>> http://cr.openjdk.java.net/~rkennke/JDK-8206407/webrev.00/
>>
>> Nice catch! Looks good!
> 
> Thanks for reviewing!
> 
> Does it qualify for trivial-doesn't-have-to-wait-24h-rule? I believe it
> does, it's 1 line that is not even touched by default.

Fine with me (assuming it still passes tier1).

/Per

> 
> Roman
> 



More information about the hotspot-gc-dev mailing list