RFR[JDK11]: 8204691: HeapRegion.apply_to_marked_objects_other_vm_test fails with assert(!hr->is_free() || hr->is_empty()) failed: Free region 0 is not empty for set Free list #
Kim Barrett
kim.barrett at oracle.com
Thu Jul 5 20:03:27 UTC 2018
> On Jul 5, 2018, at 3:57 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
>
> Hi,
>
> On Wed, 2018-07-04 at 20:13 -0400, Kim Barrett wrote:
>> Please review this fix of the HeapRegion gtest.
>>
>> The test modifies a region's "top" to unexpected values without
>> ensuring that no allocation might use the region and no GC might run
>> while the region is in that invalid state. We solve this by
>> executing the test code in its very own safepoint, and by saving and
>> then restoring the region's top back to its original value before
>> completing the test. And since we are doing all that, there's no
>> longer any reason to run the test in a separate VM.
>
> looks good, but the actual test is still run in a separate VM.
> Intentional?
Unintentional. And now I’m not sure what I last ran through mach5.
I’ll re-test with TEST_OTHER_VM => TEST_VM.
I know that failed in an obscure way earlier, but I think that was because
of an unrelated recently introduced bug that’s been fixed in the repo.
More information about the hotspot-gc-dev
mailing list