RFR (S): 8206453: Taskqueue stats should count real steal attempts, not calls to GenericTaskQueueSet::steal

Erik Helin erik.helin at oracle.com
Mon Jul 9 09:28:43 UTC 2018


On 07/09/2018 10:52 AM, Thomas Schatzl wrote:
> Hi Kim,
> 
> On Fri, 2018-07-06 at 12:33 -0400, Kim Barrett wrote:
>>> On Jul 6, 2018, at 10:11 AM, Thomas Schatzl <thomas.schatzl at oracle.
>>> com> wrote:
>>>
> [...]
>>> CR:
>>> https://bugs.openjdk.java.net/browse/JDK-8206453
>>> Webrev:
>>> http://cr.openjdk.java.net/~tschatzl/8206453/webrev/
>>> Testing:
>>> local compilation and use with and without TASKQUEUE_STATS.
>>>
>>> Thanks,
>>>   Thomas
>>
>> Please change record_attempt to record_steal_attempt.
>> Otherwise, looks good.  I don't need a new webrev for that renaming.
>>
> 
>    thanks for your review. I updated the existing webrev in-place for
> the second reviewer.

Looks good, Reviewed!

Thanks,
Erik

> Thomas
> 



More information about the hotspot-gc-dev mailing list