RFR: JDK-8154343: Make SATB related code available to other GCs

[Roman Kennke]

Am 28.07.2018 um 01:17 schrieb Kim Barrett:
>> On Jul 27, 2018, at 7:02 PM, Roman Kennke <rkennke at redhat.com> wrote:
>>
>> Am 28.07.2018 um 00:44 schrieb Kim Barrett:
>>>
>>> I’m also not sure I like the proposed new interfaces generally, but
>>> I’m still thinking about what I might like as an alternative.  Performance
>>> may drive some of that.
>>
>> I also don't like the new interfaces much. Especially polluting
>> CollectedHeap with something that GCs might not need (and in-fact, only
>> two known GCs currently need, and only one of them is currently in
>> mainline OpenJDK).
>>
>> Maybe we can define an interface like SATBSupport that provides these
>> new methods and have GCs pass in an implementation subclass at creation
>> time?
>>
>> With regards to performance, I think we can templatize the filter-loop:
>> filter() would call out to SATBSupport::filter_driver() which would call
>> back to SATBMarkQueue::filter_impl<SATBSupportType> with known
>> SATBSupportType which would then call the non-virtual and inlineable
>> SATBSupport::retain_entry() of the speficied type. This should solve all
>> performance concerns I think.
> 
> I have in mind something that I think will be simpler than that, but need
> to spend some time working through the details.  I’ll let you know what
> I come up with.

Ok, I'll wait for you then :-)

Cheers,
Roman

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20180728/6314678d/signature.asc>