RFR (XS) 8169004: arguments/TestTargetSurvivorRatioFlag.java has redundant @requires tag

Igor Ignatyev igor.ignatyev at oracle.com
Tue Jul 31 16:57:54 UTC 2018


Hi JC,

would you mind removing similar redundancy in other tests? e.g.  'vm.opt.AggressiveOpts=="false" | vm.opt.AggressiveOpts=="null"' in a few test/hotspot/jtreg/gc/g1/ tests can be replaced w/ vm.opt.AggressiveOpts != true'.

the parentheses around simple predicate seem redundant to me as well.

Thanks,
-- Igor

> On Jul 31, 2018, at 12:38 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> 
> Hi,
> 
> On Mon, 2018-07-30 at 12:28 -0700, JC Beyler wrote:
>> Hi all,
>> 
>> Could I get a few reviews for a really small webrev?
>> 
>> Webrev: http://cr.openjdk.java.net/~jcbeyler/8169004/webrev.00/
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8169004
>> 
>> Thanks!
>> Jc
> 
>  looks good and trivial. I will sponsor it.
> 
> Thanks,
>  Thomas
> 




More information about the hotspot-gc-dev mailing list