RFR (XS) 8169004: arguments/TestTargetSurvivorRatioFlag.java has redundant @requires tag

[JC Beyler]

Hi Igor,

Ah, sorry about that. Here is the webrev with fixed copyrights then:
http://cr.openjdk.java.net/~jcbeyler/8169004/webrev.02/

I'll wait for a second review since now the webrev that Thomas did review
has changed (or wait until Thomas redoes a review :-)).

Thanks!
Jc

On Tue, Jul 31, 2018 at 12:13 PM Igor Ignatyev <igor.ignatyev at oracle.com>
wrote:

> Hi JC,
>
> you should change second year instead of adding another one[*]. otherwise
> the fix looks good to me.
>
> -- Igor
>
> [*] http://mail.openjdk.java.net/pipermail/jdk7-dev/2010-May/001321.html
>
> On Jul 31, 2018, at 11:18 AM, JC Beyler <jcbeyler at google.com> wrote:
>
> Hi Igor,
>
> Here is a webrev that does the 'X == false | X == null' -> 'X != true' for
> all the ones I could find across the tests.
> I also fixed the parenthesis issue.
>
> Not sure if it was important, but I updated the copyright year for files
> that did not have 2018.
>
>
>
> http://cr.openjdk.java.net/~jcbeyler/8169004/webrev.01/jdk12-test3.changeset
>
> Let me know what you think,
> Jc
>
>
> On Tue, Jul 31, 2018 at 9:57 AM Igor Ignatyev <igor.ignatyev at oracle.com>
> wrote:
>
>> Hi JC,
>>
>> would you mind removing similar redundancy in other tests? e.g.
>> 'vm.opt.AggressiveOpts=="false" | vm.opt.AggressiveOpts=="null"' in a few
>> test/hotspot/jtreg/gc/g1/ tests can be replaced w/ vm.opt.AggressiveOpts !=
>> true'.
>>
>> the parentheses around simple predicate seem redundant to me as well.
>>
>> Thanks,
>> -- Igor
>>
>> > On Jul 31, 2018, at 12:38 AM, Thomas Schatzl <thomas.schatzl at oracle.com>
>> wrote:
>> >
>> > Hi,
>> >
>> > On Mon, 2018-07-30 at 12:28 -0700, JC Beyler wrote:
>> >> Hi all,
>> >>
>> >> Could I get a few reviews for a really small webrev?
>> >>
>> >> Webrev: http://cr.openjdk.java.net/~jcbeyler/8169004/webrev.00/
>> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8169004
>> >>
>> >> Thanks!
>> >> Jc
>> >
>> >  looks good and trivial. I will sponsor it.
>> >
>> > Thanks,
>> >  Thomas
>> >
>>
>>
>
> --
>
> Thanks,
> Jc
>
>
>

-- 

Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20180731/9a3563ad/attachment.htm>