RFR (round 4), JEP-318: Epsilon GC

Per Liden per.liden at oracle.com
Mon Jun 4 06:51:40 UTC 2018


Hi,

On 06/01/2018 10:13 AM, Jini George wrote:
[...]
> ==>  share/classes/sun/jvm/hotspot/oops/ObjectHeap.java
> 
> 445     } else {
> 446        if (Assert.ASSERTS_ENABLED) {
> 447           Assert.that(false, "Expecting GenCollectedHeap, 
> G1CollectedHeap, " +
> 448                       "or ParallelScavengeHeap, but got " +
> 449                       heap.getClass().getName());
> 450        }
> 451     }
> 
> * Please add EpsilonGC also to the assertion statement.
> 

May I suggest that we change this to something like this, to avoid 
having to update this message when a new collector is added?

Assert.that(false, "Unexpected CollectedHeap type: " + 
heap.getClass().getName());

/Per


More information about the hotspot-gc-dev mailing list