RFR: 8204287: Phase timings not updated correctly after JDK-6672778

Thomas Schatzl thomas.schatzl at oracle.com
Tue Jun 5 11:47:05 UTC 2018


Hi,

On Tue, 2018-06-05 at 13:41 +0200, Stefan Johansson wrote:
> Hi,
> 
> Please review this fix to do correct timings in G1.
> 
> Issue: https://bugs.openjdk.java.net/browse/JDK-8204287
> Webrev: http://cr.openjdk.java.net/~sjohanss/8204287/00/
> 
> Summary:
> When the partial trimming was introduced a while back the timing code
> in G1 became a bit more complicated. In one of the timer helpers a
> member structure is used before it is destructed and updated. This
> leads to the times being accounted to the wrong phases and there for
> the G1 ergonomics doing some less than optimal decisions.
> 
> Testing:
> * Local testing with jtreg
> * Mach5 testing tier 1-3 looks good
> * Sanity performance testing is running

  looks good. Thanks for finding this!

Thomas




More information about the hotspot-gc-dev mailing list