RFR (XS): 8202049: G1: ReferenceProcessor doesn't handle mark stack overflow
Kim Barrett
kim.barrett at oracle.com
Tue Jun 5 13:08:33 UTC 2018
> On Jun 5, 2018, at 3:56 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
>
> Hi,
>
> On Mon, 2018-06-04 at 20:26 -0400, Kim Barrett wrote:
>>> On Jun 4, 2018, at 6:35 AM, Thomas Schatzl <thomas.schatzl at oracle.c
>>> om> wrote:
>>> CR:
>>> https://bugs.openjdk.java.net/browse/JDK-8202049
>>> Webrev:
>>> http://cr.openjdk.java.net/~tschatzl/8202049/webrev
>>> Testing:
>>> running this patch for months in my usual testing routine for other
>>> patches without any error.
>>>
>>> Thanks,
>>> Thomas
>>
>> I think this ought to use fatal(...) rather than log_error +
>> ShouldNotReachHere.
>>
>
> fixed in place.
>
> Due to precedent in other code I was swaying between both, apparently
> to the wrong side.
>
> Thanks,
> Thomas
Looks good.
More information about the hotspot-gc-dev
mailing list