RFR: 8204538: Split ScanClosure and ScanClosureWithParBarrier

Stefan Karlsson stefan.karlsson at oracle.com
Thu Jun 7 13:13:20 UTC 2018


Hi Thomas,

On 2018-06-07 15:07, Thomas Schatzl wrote:
> Hi,
> 
> On Thu, 2018-06-07 at 12:16 +0200, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review this patch to change ScanClosureWithParBarrier to not
>> inherit from ScanClosure.
>>
>> http://cr.openjdk.java.net/~stefank/8204538/webrev.01/
>> https://bugs.openjdk.java.net/browse/JDK-8204538
>>
>> ScanClosureWithParBarrier is the only ExtendedOopClosure sub class
>> that  overrides the do_oop functions of a super class. This patch
>> cleans this up to pave the way for:
>>
>>    https://bugs.openjdk.java.net/browse/JDK-8204540 - Automatic oop
>> closure devirtualization
> 
>    looks good.

Thanks!

> 
> Is there a way to automatically determine such issues?

I mused a bit about that in the RFE linked above.

StefanK

> 
> Thanks,
>    Thomas
> 



More information about the hotspot-gc-dev mailing list