RFR: JDK-8204685: Abstraction for TLAB dummy object
Roman Kennke
rkennke at redhat.com
Wed Jun 13 08:14:46 UTC 2018
Am 13.06.2018 um 10:09 schrieb Aleksey Shipilev:
> On 06/12/2018 06:40 PM, Roman Kennke wrote:
>> Right.
>> http://cr.openjdk.java.net/~rkennke/JDK-8204685/webrev.01/
>
> It looks okay.
>
> Looking closer to whole thing again. What is enforcing the use of this new method? I would expect
> only fill_with_dummy_object be available to non-CollectedHeap callers, which means other methods
> e.g. fill_with_object to become protected/private. Looking at how proliferated the use of those
> methods are within the GCs, it seems some "friend"-ing is in order. Can be done in a separate RFE.
>
> -Aleksey
>
Right. I filed:
https://bugs.openjdk.java.net/browse/JDK-8204940
and will handle it there.
Thanks for reviewing!
Roman
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20180613/20897b62/signature.asc>
More information about the hotspot-gc-dev
mailing list