RFR (S): 8204082: Make names of Young GCs more uniform in logs

[Kirk Pepperdine]

Hi Thomas,

>From a parsing POV would be preferable "Pause Young Normal" would be
preferable to Pause Young (Normal)".  I know it's a small change but it
does make a difference. The rest of the code is fine (of course not an
official review).

As for the change it's self, [73.077s][info ][gc,start     ] GC(262) Pause
Initial Mark (G1 Humongous Allocation) is already perfectly clear to me.
I'm not sure how
[73.077s][info ][gc,start     ] GC(262) Pause Young (Initial Mark)  (G1
Humongous Allocation) clarifies things. IMO, this change only adds to the
already high level of noise in the GC logs. On that note, I have time
scheduled in July to see what can be done to reduce redundancy in the logs.

Kind regards,
Kirk



On Thu, Jun 14, 2018 at 4:02 PM, Thomas Schatzl <thomas.schatzl at oracle.com>
wrote:

> Hi all,
>
>   another round of reviews after some more internal remarks :P
>
> I also changed the title of the CR.
>
> The set of "final" tags would be:
>
> Pause Young (Normal) ...
> Pause Young (Concurrent Start) ...
> Pause Young (Concurrent End) ...
> Pause Young (Mixed) ...
>
> I also adapted the strings in the GCVerifyType functionality.
>
> http://cr.openjdk.java.net/~tschatzl/8204082/webrev.1_to_2 (diff)
> http://cr.openjdk.java.net/~tschatzl/8204082/webrev.2 (full)
>
> Testing:
> running through all gc tests locally
>
> Thanks,
>   Thomas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20180615/e76a06ab/attachment.htm>