RFR: 8205344: TraceMemoryManagerStats changes in JDK-8195115 broke ZGC

Per Liden per.liden at oracle.com
Tue Jun 19 16:31:48 UTC 2018


On 06/19/2018 06:23 PM, Aleksey Shipilev wrote:
> On 06/19/2018 06:19 PM, Per Liden wrote:
>> JDK-8195115 changed the TraceMemoryManagerStats constructor interface but failed to take ZGC into
>> account, causing failure in Tier2 testing. This patch should restore the previous behavior for ZGC.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8205344
>> Webrev: http://cr.openjdk.java.net/~pliden/8205344/webrev.0
> 
> Looks good.

Thanks!

> 
> -Aleksey
> 
> P.S. (in grandpa voice) See, this is why experimental GCs should built by default in OpenJDK
> upstream: we would not have to play catch-up with simple breaking changes. ;)

In this case, I don't think it would have been caught anyway since it's 
not a build error (thanks to those damn default values on arguments). 
You actually need to run the specific test with -XX:+UseZGC to see it.

cheers,
Per



More information about the hotspot-gc-dev mailing list