RFR(M): 8204524: Unnecessary memory barriers in G1ParScanThreadState::copy_to_survivor_space

Doerr, Martin martin.doerr at sap.com
Fri Jun 22 14:29:43 UTC 2018


Hi Thomas,

submission repo testing has passed and it was "Reviewed-by: kbarrett, mdoerr, drwhite, tschatzl" if I see it correctly.
I'll push it next week if I hear no objections.

Thanks, Martin


-----Original Message-----
From: Thomas Schatzl [mailto:thomas.schatzl at oracle.com] 
Sent: Mittwoch, 20. Juni 2018 14:15
To: Michihiro Horie <HORIE at jp.ibm.com>; Doerr, Martin <martin.doerr at sap.com>; Kim Barrett <kim.barrett at oracle.com>
Cc: Gustavo Bueno Romero <gromero at br.ibm.com>; david.holmes at oracle.com; hotspot-gc-dev at openjdk.java.net
Subject: Re: RFR(M): 8204524: Unnecessary memory barriers in G1ParScanThreadState::copy_to_survivor_space

Hi,

On Wed, 2018-06-20 at 07:41 -0400, Michihiro Horie wrote:
> Hi Martin, Kim, all,
> 
> > I assume webrev.00 was used for reviews and tests as Thomas has 
> > emphasized that evacuation failures may be performance critical, 
> > too. It looks correct to me, too.
> > 
> > I can sponsor the change if needed. Please let me know when I can 
> > consider it reviewed.
> 
> Thanks a lot for sponsoring the change, Martin. Yes, webrev.00 is the
> one used for the review:
> http://cr.openjdk.java.net/~mhorie/8204524/webrev.00/
> 
> I think Kim would review the change because Derek concluded there is
> a moderate performance gain in SPECjbb on AArch64. Kim, would you
> agree with this change?

Kim is on vacation, but from the context of his review he looked at the
00 change, not the later, reduced 01 one (http://mail.openjdk.java.net/
pipermail/hotspot-gc-dev/2018-June/022358.html).

So I guess it can be considered as reviewed from our POV.

Thanks,
  Thomas



More information about the hotspot-gc-dev mailing list