RFR: 8205679: Remove unused ThreadLocalAllocBuffer::undo_allocate()

[Aleksey Shipilev]

On 06/27/2018 10:53 AM, Per Liden wrote:
> Hi Aleksey,
> 
> Thanks for reviewing.
> 
> On 06/26/2018 06:09 PM, Aleksey Shipilev wrote:
>> On 06/26/2018 12:45 PM, Per Liden wrote:
>>> After JDK-8205676, the function ThreadLocalAllocBuffer::undo_allocate() is unused and can be
>>> removed.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8205679
>>> Webrev: http://cr.openjdk.java.net/~pliden/8205679/webrev.0
>>
>> The patch looks good, but the method itself looks generic enough to keep around. At some point,
>> Shenandoah may switch to using this instead of PLABs.
> 
> We typically don't leave unused code around (as it tends to rot quickly), unless we know it will be
> used in the near/mid-term future. So, I guess the question is, are you already using this in the
> shanandoah repo, or will soon-ish? [1] If not I'd prefer to remove it. The hg history will preserve
> it, so it's trivial to bring it back if you find that you really do needed it in the future.

We don't have the patch in Shenandoah repos yet. OK, let's remove it, and reinstate later if needed.

-Aleksey

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20180628/0e85ee27/signature.asc>