RFR: 8199024: Remove unneccessary protected and virtual modifiers from G1CollectedHeap

Kim Barrett kim.barrett at oracle.com
Mon Mar 5 23:27:23 UTC 2018


> On Mar 5, 2018, at 11:44 AM, Erik Helin <erik.helin at oracle.com> wrote:
> 
> Hi all,
> 
> this tiny patch cleans up the visibility for members in G1CollectedHeap a bit. There is no need for protected members, I also removed two unnecessary virtual modifiers.
> 
> Issue:
> https://bugs.openjdk.java.net/browse/JDK-8199024
> 
> Patch:
> http://cr.openjdk.java.net/~ehelin/8199024/00/
> 
> Testing:
> - make run-test-tier1 on Linux, macOS, Windows (x86-64) and
>                         Solaris (SPARC and x86-64)
> 
> Thanks,
> Erik

Looks good.

The (pre-existing) placement of the declarations for pending_card_num() and _max_heap_capacity
at the end of the class seems odd.  I don’t need a new webrev if you want to move them to some
more logical place in the class.




More information about the hotspot-gc-dev mailing list