RFR [S][2/7] 8197570: Make rules for choosing collection set candidates more explicit

Thomas Schatzl thomas.schatzl at oracle.com
Tue Mar 6 13:18:37 UTC 2018


Hi Stefan,

On Mon, 2018-03-05 at 16:19 +0100, Stefan Johansson wrote:
> Hi Thomas,
> 
> On 2018-03-05 15:22, Thomas Schatzl wrote:
> > Hi all,
> > 
> >    can I have reviews for this change that makes the rule
> > (occupancy) for choosing collection set candidates more explicit,
> > i.e. factor it into a single method. This is needed for selecting
> > the regions we want to rebuild the remembered sets concurrently
> > (JDK-8180415) more straightforward.
> > 
> > It also adds a method to allow iteration over the regions in the
> > collection set - I did not see that worth an extra webrev.
> > 
> > CR:
> > https://bugs.openjdk.java.net/browse/JDK-8197570
> > Webrev:
> > http://cr.openjdk.java.net/~tschatzl/8197570/webrev/
> 
> Looks good,

  thanks for your review.

Thomas




More information about the hotspot-gc-dev mailing list