RFR(XS): JDK-8199559: objArrayKlass::oop_iterate() and friends must use base_raw() instead of base()

Erik Österlund erik.osterlund at oracle.com
Wed Mar 14 10:16:35 UTC 2018


Hi Roman,

Looks good.

Thanks,
/Erik

On 2018-03-13 21:00, Roman Kennke wrote:
> Currently, objArrayKlass::oop_iterate() and related methods use base()
> to get the actual starting address of the array. However, base()
> resolves the oop via barriers. oop_iterate() is used solely by GC code,
> which requires direct access to the array, no matter which copy, and
> thus needs to use base_raw() instead.
>
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8199559
> Webrev:
> http://cr.openjdk.java.net/~rkennke/8199559/webrev.00/
>
> Can I please get a review?
>
> Thanks, Roman
>




More information about the hotspot-gc-dev mailing list