RFR [L][4/7]: 8180415: Rebuild remembered sets during the concurrent cycle

[Stefan Johansson]

On 2018-03-22 11:37, Thomas Schatzl wrote:
> ...
> All done.
>
> http://cr.openjdk.java.net/~tschatzl/8180415/webrev.3_to_4 (diff)
> http://cr.openjdk.java.net/~tschatzl/8180415/webrev.4 (full)
Looks good to me too, just one very minor thing. The second comment in 
g1RemSet.cpp still calls it nTAMS, is that on purpose? No need for a 
re-review, just update it if you want.

Thanks,
Stefan

> In addition to that I added the following minor changes:
> - renamed the "CLEAR_REMEMBERED_SET" phase in the concurrent gc phase
> manager to "REBUILD_REMEMBERED_Set" as this matches the code better.
>
> - several fixes to later re-enable the TestVerifyGCType (JDK-8193067:
> gc/g1/TestVerifyGCType.java still unstable) later. That test parses the
> log messages done during verification, and expects them to have a
> "During GC" prefix.
>
> - there is one minor I think pre-existing issue fixed, in
> g1Policy.cpp::decide_on_conc_mark_initiation(): it is possible that a
> user initiated concurrent mark request can happen right after the
> Cleanup pause before the "last gc before mixed gc". During that time
> there is a collection set, and that one gets messed up in the following
> marking (the evacuation efficiency of the regions may change). This
> triggers some (benign) assert in the collection set chooser.
> We need to clear any existing collection set before initiating
> concurrent mark.
>
> Thanks,
>    Thomas
>
>