RFR: 8199850: Move parsing of VerifyGCType to G1

[Per Liden]

Thanks for reviewing Stefan and Thomas!

/Per

On 03/23/2018 11:31 AM, Thomas Schatzl wrote:
> Hi,
> 
> On Fri, 2018-03-23 at 10:27 +0100, Per Liden wrote:
>> Hi Thomas,
>>
>> On 03/22/2018 05:20 PM, Thomas Schatzl wrote:
>>> Hi,
>>>
>>> On Tue, 2018-03-20 at 10:11 +0100, Per Liden wrote:
>>>> When JDK-8191821 introduced the VerifyGCType option for G1 I
>>>> didn't
>>>> quite see the need for this to affect the GCArguments class. I'm
>>>> proposing we move this logic into G1HeapVerifier, which I believe
>>>> is
>>>> a better place for this.
>>>
>>> I would actually prefer this parsing to be located and called by
>>> the
>>> G1Arguments class. I really dislike the (existing) G1 habit of
>>> every
>>> class doing its own arguments parsing.
>>>
>>> It's much more convenient to have one place to look at compared to
>>> first searching where it's actually parsed.
>>>
>>> I do agree that since it is not supported by other collectors
>>> (yet?)
>>> the shared code may not be the perfect place for it.
>>>
>>> However if others disagree, keep it this way.
>>
>> No problem. Here's an updated webrev, which moves the arguments
>> parsing
>> logic to G1Arguments.
>>
>> http://cr.openjdk.java.net/~pliden/8199850/webrev.1
>>
> 
>    looks good.
> 
> Thomas
>