RFR (S): 8196485: FromCardCache default card index can cause crashes

Thomas Schatzl thomas.schatzl at oracle.com
Mon Mar 26 10:04:41 UTC 2018


Hi Aleksey,

On Fri, 2018-03-23 at 09:45 +0100, Aleksey Shipilev wrote:
> On 03/08/2018 09:59 AM, Thomas Schatzl wrote:
> > CR:
> > https://bugs.openjdk.java.net/browse/JDK-8196485
> > Webrev:
> > http://cr.openjdk.java.net/~tschatzl/8196485/webrev/
> 
> Ha! Ouch. Looks good, except:
> 

Yeah :/

> *) I feel uneasy about assigning negative values to unsigned vars.
> Intended to be UINTPTR_MAX?
> 
> static const uintptr_t InvalidCard = -1;
> 
> *) "heap region" here, probably:
> 
>  134   // of the given heapregion.

I updated the webrev in place with these fixes.

Thanks for your review.

Thomas



More information about the hotspot-gc-dev mailing list