RFR (M): 8199742: Clean up state flags in G1CollectorState

Thomas Schatzl thomas.schatzl at oracle.com
Tue Mar 27 13:25:20 UTC 2018


Hi Stefan,

On Tue, 2018-03-27 at 14:58 +0200, Stefan Johansson wrote:
> Hi Thomas,
> 
> Thanks for this much needed cleanup :)
> 
> On 2018-03-26 17:06, Thomas Schatzl wrote:
> > Hi all,
> > 
> >    I would like to request reviews for this change that cleans up
> > the flags in G1CollectorState, applying uniform naming, removing
> > members that were basically temporary variables for a single
> > method, and [...]
> > CR:
> > https://bugs.openjdk.java.net/browse/JDK-8199742
> > Webrev:
> > http://cr.openjdk.java.net/~tschatzl/8199742/webrev
> 
> The change looks good. Just some minor things, gc_are_young and 
> during_im are used as local variables at some places. I think we
> could change those to reflect the new better names as well.

I grepped through the sources for the old names and changed the uses to
something better (I hope).

http://cr.openjdk.java.net/~tschatzl/8199742/webrev.0_to_1 (diff)
http://cr.openjdk.java.net/~tschatzl/8199742/webrev.1 (full)

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list