RFR (S): 8200305: Update gc,liveness output with remset state after rebuild remset concurrently changes

sangheon.kim sangheon.kim at oracle.com
Wed Mar 28 18:18:50 UTC 2018


Hi Thomas,

On 03/28/2018 08:26 AM, Thomas Schatzl wrote:
> Hi all,
>
>    can I have reviews for this change that updates the gc,liveness
> output to add the remembered set state?
>
> This change adds a column next to "remset" called "state" that can be
> either UNTRA (Untracked), UPDAT (Updating) and CMPLT (Complete).
>
> There is a log snippet attached that shows the new output.
>
> If somebody asks, I kind of agree that we should probably rethink this
> output (remove some of the addresses, add region number), but this is
> imho out of scope for this change. ;]
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8200305
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8200305/webrev/
> Testing:
> local verification
Looks good as is.

Adding the state is a good idea.
But these short version strings are not easy to catch. Just printing 
original strings(9 characters) are too long? :)

Thanks,
Sangheon


>
> Thanks,
>    Thomas
>




More information about the hotspot-gc-dev mailing list