RFR (S): 8200426: Make G1 code use _g1h members

sangheon.kim sangheon.kim at oracle.com
Thu Mar 29 17:10:41 UTC 2018


Hi Thomas,

Thank you for addressing this cleanup!

On 03/29/2018 07:19 AM, Thomas Schatzl wrote:
> Hi all,
>
>    can I have reviews for this change that tries to make the use of
> locally cached members of G1CollectedHeap* uniform by actually using it
> and renaming the members uniformly to "g1h".
>
> This change has been suggested in a recent review.
>
> There has not actually been a lot to change.
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8200426
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8200426/webrev
Looks good.
And I found more.

================================================
src/hotspot/share/gc/g1/g1CollectedHeap.cpp
3644 G1CollectedHeap* _g1;
3663 G1CollectedHeap* _g1;

================================================
src/hotspot/share/gc/g1/g1CollectedHeap.hpp
111    G1CollectedHeap* _g1;

================================================
src/hotspot/share/gc/g1/g1EvacFailure.cpp
42   G1CollectedHeap* _g1;
73   G1CollectedHeap* _g1;

================================================
src/hotspot/share/gc/g1/g1HeapSizingPolicy.hpp
39   const G1CollectedHeap* _g1;

================================================
src/hotspot/share/gc/g1/g1OopClosures.hpp
44  G1CollectedHeap* _g1;
107    G1CollectedHeap* _g1;
191    G1CollectedHeap* _g1;
209    G1CollectedHeap* _g1;

================================================
src/hotspot/share/gc/g1/g1Policy.hpp
   184    G1CollectedHeap* _g1

================================================
src/hotspot/share/gc/g1/g1RemSet.hpp
72  G1CollectedHeap* _g1;

================================================
src/hotspot/share/gc/g1/g1MonitoringSupport.cpp
243   G1CollectedHeap* g1 = g1h();
(This is a bonus :) )
- We don't need this line as line 248 also gets g1h.

Thanks,
Sangheon

> Testing:
> local compilation
>
> Thanks,
>    Thomas




More information about the hotspot-gc-dev mailing list