RFR (round 3), JEP-318: Epsilon GC
Per Liden
per.liden at oracle.com
Wed May 30 11:25:50 UTC 2018
On 05/30/2018 12:54 PM, Aleksey Shipilev wrote:
> On 05/30/2018 12:42 PM, Per Liden wrote:
>>>>> Please keep the #if INCLUDE_XXX, XXX_ONLY and NOT_XXX sections sorted alphabetically. I.e. CMS -
>>>>> Epsilon - G1 ...
>>>
>>> Yup:
>>> http://hg.openjdk.java.net/jdk/sandbox/rev/547ded4c0de6
>>
>> Looks good!
>>
>> Minor nit, the indentation in vmStructs_gc.hpp looks off by 2 a few places:
>>
>> + EPSILONGC_ONLY(VM_STRUCTS_EPSILONGC(nonstatic_field,
>> \
>> + volatile_nonstatic_field,
>> \
>> + static_field))
>> \
>>
>>
>> + EPSILONGC_ONLY(VM_TYPES_EPSILONGC(declare_type, \
>> + declare_toplevel_type, \
>> + declare_integer_type)) \
>>
>>
>> + EPSILONGC_ONLY(VM_INT_CONSTANTS_EPSILONGC(declare_constant, \
>> + declare_constant_with_value)) \
>
> Oh. Took me a while to see it. Fixed:
> http://hg.openjdk.java.net/jdk/sandbox/rev/14ebf728ce3f
Looks good!
/Per
>
> -Aleksey
>
More information about the hotspot-gc-dev
mailing list