RFR (S): 8211388: Make OtherRegionsTable independent of the region it is for
Thomas Schatzl
thomas.schatzl at oracle.com
Tue Oct 30 09:45:07 UTC 2018
Hi Sangheon,
On Mon, 2018-10-29 at 15:05 -0700, sangheon.kim at oracle.com wrote:
> Hi Thomas,
>
> On 10/15/18 3:59 AM, Thomas Schatzl wrote:
> > Hi all,
> >
> > ping for a second review...
> >
> > Thomas
> >
> > On Tue, 2018-10-02 at 17:58 +0200, Thomas Schatzl wrote:
> > > Hi,
> > >
> > > the OtherRegionsTable is a set of a set of cards that
> > > comprises the remembered set.
> > > [...]
> > > CR:
> > > https://bugs.openjdk.java.net/browse/JDK-8211388
> > > Webrev:
> > > http://cr.openjdk.java.net/~tschatzl/8211388/webrev/
>
> Looks good.
> But please modify below line before pushing it. I don't need extra
> webrev for this.
>
> -------------------------------------------
> src/hotspot/share/gc/g1/heapRegionRemSet.hpp
>
> 126 // Create a new remembered set for the given heap region. The
> given mutex should
> 127 // be used to ensure consistency.
>
> - You removed heap region parameter, so some part of above comment
> should be modified. :)
:)
For reference, the new webrevs:
http://cr.openjdk.java.net/~tschatzl/8211388/webrev.0_to_1 (diff)
http://cr.openjdk.java.net/~tschatzl/8211388/webrev.1 (full)
Thanks,
Thomas
More information about the hotspot-gc-dev
mailing list