RFR (XXS): 8210463: Recalculate_used() always sets time taken in G1GCPhaseTimes

Hohensee, Paul hohensee at amazon.com
Fri Sep 7 13:59:10 UTC 2018


The only other uses of recalculate_used() that I see are in asserts, so this lgtm.

Paul

On 9/7/18, 6:40 AM, "hotspot-gc-dev on behalf of Thomas Schatzl" <hotspot-gc-dev-bounces at openjdk.java.net on behalf of thomas.schatzl at oracle.com> wrote:

    Hi,
    
      can I have reviews for this refactoring of
    G1CollectedHeap::recalculate_used() to move out time measurement from
    this method to the only place where we intend to measure the time that
    operation takes?
    In the other cases we use recalculate_used() only in asserts.
    
    While it does not really hurt because the wrong values are never read
    from, it's still a matter of cleaning up the code imho.
    
    CR:
    https://bugs.openjdk.java.net/browse/JDK-8210463
    Webrev:
    http://cr.openjdk.java.net/~tschatzl/8210463/webrev/
    Testing:
    manual checking that time is still reported for the only case we care
    
    Thanks,
      Thomas
    
    



More information about the hotspot-gc-dev mailing list