RFR: 8210713: Let CollectedHeap::ensure_parsability() take care of TLAB statistics gathering
Erik Österlund
erik.osterlund at oracle.com
Fri Sep 14 08:04:08 UTC 2018
Hi Per,
Looks good.
Thanks,
/Erik
On 2018-09-13 13:46, Per Liden wrote:
> A call to CollectedHeap::ensure_parsability(retire_tlabs), where
> retire_tlabs is true must always be preceded by a call to
> CollectedHeap::accumulate_statistics_all_tlabs(), otherwise we will
> loose TLAB statistics as it will be reset when the TLABs are retired.
> Instead of having all collectors do this dance and risk getting it
> wrong, I propose that we move this responsibility into
> ensure_parsability(), which will gather the TLAB statistics if it's
> told to retire all TLABs.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8210713
> Webrev: http://cr.openjdk.java.net/~pliden/8210713/webrev.0
>
> /Per
More information about the hotspot-gc-dev
mailing list