RFR: 8221836: Avoid recalculating String.hash when zero
Peter Levart
peter.levart at gmail.com
Tue Apr 9 09:04:36 UTC 2019
On 4/9/19 10:42 AM, Claes Redestad wrote:
> Hi Andrew,
>
> On 2019-04-09 10:20, Andrew Dinn wrote:
>> If the patch is to go in -- and I concede there is an acceptable
>> argument for that -- then it
>> needs commenting to help avoid this happening.
>
> open.02 already adds what I believed to be sufficient commenting, have
> you taken this into consideration?
>
> http://cr.openjdk.java.net/~redestad/8221836/open.02/src/java.base/share/classes/java/lang/String.java.udiff.html
>
>
> /Claes
Perhaps you could add the same comment to the C++
java_lang_String::hash_code(oop java_string) method too?
Regards, Peter
More information about the hotspot-gc-dev
mailing list