RFR(XXS) 8222188: Shenandoah: Adjust Shenandoah work gang types

Roman Kennke rkennke at redhat.com
Tue Apr 9 19:58:28 UTC 2019


Looks good, thanks!



> Hi Roman,
> 
> On 4/9/19 10:31 AM, Roman Kennke wrote:
> > I'd be careful with this, and not change it unless we really have
> > to.
> > Have you checked if we use any of is_ConcurrentGC_thread(),
> > is_Worker_thread(), is_GC_task_thread() anywhere? I believe the OOM
> > handler might use this to differenciate different types of threads.
> 
> I reverted safepoint_workers change.
> 
> There are only two is_ConcurrentGC_thread() checks, both are in 
> assertion code, updated accordingly.
> 
> New webrev: http://cr.openjdk.java.net/~zgu/JDK-8222188/webrev.01/
> 
> Thanks,
> 
> -Zhengyu
> 
> > Roman
> > 
> > > Am Dienstag, den 09.04.2019, 10:13 -0400 schrieb Zhengyu Gu:
> > > This is a cleanup in preparation for concurrent class unloading.
> > > 
> > > Bug: https://bugs.openjdk.java.net/browse/JDK-8222188
> > > Webrev:
> > > http://cr.openjdk.java.net/~zgu/JDK-8222188/webrev.00/index.html
> > > 
> > > Test:
> > >     hotspot_gc_shenandoah on Linux 64 (fastdebug and release)
> > > 
> > > Thanks,
> > > 
> > > -Zhengyu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20190409/f5016650/signature.asc>


More information about the hotspot-gc-dev mailing list