RFR: 8224666: Parallel GC: Use WorkGang (8: obsolete and remove flags)

Leo Korinth leo.korinth at oracle.com
Mon Aug 5 16:27:01 UTC 2019



On 28/07/2019 20:19, Thomas Schatzl wrote:
> Hi,
> 
> On 20.07.19 04:55, Kim Barrett wrote:
>>> On May 29, 2019, at 8:55 AM, Leo Korinth <leo.korinth at oracle.com> wrote:
>>>
>>> Hi,
>>>
>>> Here is the eighth and last patch that removes gcTaskManager and uses
>>> the WorkGang abstraction instead.
> [...]
>>>
>>> Enhancement:
>>>   https://bugs.openjdk.java.net/browse/JDK-8224666
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~lkorinth/workgang/0/_8224666-Parallel-GC-Use-WorkGang-8-obsolete-and-remove-flags/ 
>>>
>>>   http://cr.openjdk.java.net/~lkorinth/workgang/0/all/
>>>
>>> Testing (on the whole patch series):
>>>   mach5 remote-build-and-test --build-profiles 
>>> linux-x64,linux-x64-debug,macosx-x64,solaris-sparcv9,windows-x64 
>>> --test open/test/hotspot/jtreg/:hotspot_gc -a -XX:+UseParallelGC
>>>   gc test suite
>>>
>>> Thanks,
>>> Leo
>>
>> 8224666-Parallel-GC-Use-WorkGang-8-obsolete-and-remove-flags
>> 8224666-Parallel-GC-Use-WorkGang-8-obsolete-and-remove-flags-fixup-1
>>
>> Looks good.
>>
>> I see there is a draft CSR for removal of these product flags
>> (JDK-8224668).  I think it needs to be pushed along in the state
>> machine so it can be reviewed.  I've reviewed the current text and it
>> looks okay to me.
>>
> 
> I udpated the CSR a little too and signed it. Not sure if we should keep 
> the name since it is not descriptive enough. We should ask  if it is 
> possible to have different names for CSR and bugfix.
> 
> Thanks,
>    Thomas

I changed the title to:
Parallel GC: Obsolete and remove flags BindGCTaskThreadsToCPUs and 
UseGCTaskAffinity

Is that better? If you have a better suggestion please change the title, 
I will probably agree :-)

Is there anything more I need to do?

Thanks,
Leo



More information about the hotspot-gc-dev mailing list