RFR (S): 8227442: Make young_index_in_cset zero-based

Thomas Schatzl thomas.schatzl at oracle.com
Tue Aug 20 08:08:26 UTC 2019


Hi Kim, Sangheon,

On Mon, 2019-08-19 at 21:14 -0700, sangheon.kim at oracle.com wrote:
> Hi Thomas,
> 
> On 8/19/19 6:46 AM, Thomas Schatzl wrote:
> > Hi Kim, 
> > 
> >   thanks for your review. 
> > 
> > On 17.08.19 06:48, Kim Barrett wrote: 
> > > > On Aug 7, 2019, at 6:39 AM, Thomas Schatzl <
> > > > thomas.schatzl at oracle.com> wrote: 
> > > > 
> > > > Hi all, 
> > > > 
> > > >   can I have reviews for this refactoring that changes the
> > > > minimum index for the young indices (used for determining
> > > > survivors per young region) from -1 to 0? 
> > > > 
> > > > This avoids some imho unnecessary increment in the
> > > > copy_to_survivor_space() method. 
> > > > 
> > > > [...]
> >  
> > http://cr.openjdk.java.net/~tschatzl/8227442/webrev.0_to_1/ (diff) 
> > http://cr.openjdk.java.net/~tschatzl/8227442/webrev.1/ (full) 
>  webrev.1 looks good.
> 
> One minor nit:
> src/hotspot/share/gc/g1/heapRegion.hpp
>  618       assert( _age_index == -1, "pre-condition");
> - Still there is a whitespace before '_age_index'. Please remove it
> before the push.

  thanks for your reviews. Pushed with this suggestion.

Thanks,
  Thomas





More information about the hotspot-gc-dev mailing list